From: jiil.hyoun Date: Mon, 27 Aug 2012 01:38:25 +0000 (+0900) Subject: [Title] change puts to raise for error handling X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=13047d7579e6a0b1293cfdf6f9630b98f57c610b;p=sdk%2Ftools%2Fsdk-build.git [Title] change puts to raise for error handling [Type] Enhancement [Module] Toolchain / [Priority] Minor [Jira#] [Redmine#] [Problem] [Cause] [Solution] [TestCase] Change-Id: Ic80442ebf131f75b045876dfb1777e72956bc1a3 --- diff --git a/src/build_server/BuildClientOptionParser.rb b/src/build_server/BuildClientOptionParser.rb index 005db89..f75afbb 100644 --- a/src/build_server/BuildClientOptionParser.rb +++ b/src/build_server/BuildClientOptionParser.rb @@ -129,8 +129,7 @@ def option_parse options[:os] = nil opts.on( '-o', '--os ', 'target operating system: ubuntu-32/ubuntu-64/windows-32/windows-64/macos-64' ) do |os| if not Utils.multi_argument_test( os, "," ) then - puts "OS variable parsing error : #{os}" - exit + raise ArgumentError, "OS variable parsing error : #{os}" end options[:os] = os end diff --git a/src/build_server/BuildServerOptionParser.rb b/src/build_server/BuildServerOptionParser.rb index c641c22..14be325 100644 --- a/src/build_server/BuildServerOptionParser.rb +++ b/src/build_server/BuildServerOptionParser.rb @@ -151,8 +151,7 @@ def option_parse options[:os] = nil opts.on( '-o', '--os ', 'ex) linux-32,windows-32' ) do|os| if not Utils.multi_argument_test( os, "," ) then - puts "OS variable parsing error : #{os}" - exit + raise ArgumentError, "OS variable parsing error : #{os}" end options[:os] = os end diff --git a/src/pkg_server/serverOptParser.rb b/src/pkg_server/serverOptParser.rb index 1590466..1483fcc 100644 --- a/src/pkg_server/serverOptParser.rb +++ b/src/pkg_server/serverOptParser.rb @@ -164,8 +164,7 @@ def option_parse opts.on( '-P', '--pkgs ', 'package file path list' ) do|pkgs| if not Utils.multi_argument_test( pkgs, "," ) then - puts "Package variable parsing error : #{pkgs}" - exit + raise ArgumentError, "Package variable parsing error : #{pkgs}" end list = pkgs.tr(" \t","").split(",") list.each do |l| @@ -176,8 +175,7 @@ def option_parse opts.on( '-s', '--snapshot ', 'a snapshot name or snapshot list' ) do|snaplist| if not Utils.multi_argument_test( snaplist, "," ) then - puts "Snapshot variable parsing error : #{snaplist}" - exit + raise ArgumentError, "Snapshot variable parsing error : #{snaplist}" end options[:snaps] = snaplist.split(",") end