From: Jingoo Han Date: Mon, 9 Dec 2013 03:28:28 +0000 (+0900) Subject: irda: via-ircc: remove unnecessary pci_set_drvdata() X-Git-Tag: accepted/tizen/common/20141203.182822~719^2~575 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=12c51e13a1e54a2604e311b6fba01cb61636210b;p=platform%2Fkernel%2Flinux-arm64.git irda: via-ircc: remove unnecessary pci_set_drvdata() The driver core clears the driver data to NULL after device_release or on probe failure. Thus, it is not needed to manually clear the device driver data to NULL. Signed-off-by: Jingoo Han Signed-off-by: David S. Miller --- diff --git a/drivers/net/irda/via-ircc.c b/drivers/net/irda/via-ircc.c index 26cb45d..2900af0 100644 --- a/drivers/net/irda/via-ircc.c +++ b/drivers/net/irda/via-ircc.c @@ -407,7 +407,6 @@ static int via_ircc_open(struct pci_dev *pdev, chipio_t *info, unsigned int id) err_out2: release_region(self->io.fir_base, self->io.fir_ext); err_out1: - pci_set_drvdata(pdev, NULL); free_netdev(dev); return err; } @@ -441,7 +440,6 @@ static void via_remove_one(struct pci_dev *pdev) if (self->rx_buff.head) dma_free_coherent(&pdev->dev, self->rx_buff.truesize, self->rx_buff.head, self->rx_buff_dma); - pci_set_drvdata(pdev, NULL); free_netdev(self->netdev);