From: Wei Yongjun Date: Tue, 23 Oct 2012 05:35:46 +0000 (+0800) Subject: usb: musb: davinci: use platform_device_unregister in davinci_remove() X-Git-Tag: upstream/snapshot3+hdmi~6133^2~61^2~16 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=12a71f5b1ce510335c720443b6eec691ed3cf906;p=platform%2Fadaptation%2Frenesas_rcar%2Frenesas_kernel.git usb: musb: davinci: use platform_device_unregister in davinci_remove() platform_device_unregister() only calls platform_device_del() and platform_device_put(), thus use platform_device_unregister() to simplify the code. Also the documents in platform.c shows that platform_device_del and platform_device_put must _only_ be externally called in error cases. All other usage is a bug. dpatch engine is used to auto generate this patch. (https://github.com/weiyj/dpatch) Signed-off-by: Wei Yongjun Signed-off-by: Felipe Balbi --- diff --git a/drivers/usb/musb/davinci.c b/drivers/usb/musb/davinci.c index 62785bf..959a6d7 100644 --- a/drivers/usb/musb/davinci.c +++ b/drivers/usb/musb/davinci.c @@ -605,8 +605,7 @@ static int __devexit davinci_remove(struct platform_device *pdev) struct davinci_glue *glue = platform_get_drvdata(pdev); musb_put_id(&pdev->dev, glue->musb->id); - platform_device_del(glue->musb); - platform_device_put(glue->musb); + platform_device_unregister(glue->musb); clk_disable(glue->clk); clk_put(glue->clk); kfree(glue);