From: Michal Schmidt Date: Thu, 15 Mar 2012 14:08:28 +0000 (+0000) Subject: bnx2x: fix a crash on corrupt firmware file X-Git-Tag: v3.3~2^2~6 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=127d0a198a310970b31866af8bbb6d4b1068e546;p=profile%2Fivi%2Fkernel-adaptation-intel-automotive.git bnx2x: fix a crash on corrupt firmware file If the requested firmware is deemed corrupt and then released, reset the pointer to NULL in order to avoid double-freeing it in bnx2x_release_firmware() or dereferencing it in bnx2x_init_firmware(). Signed-off-by: Michal Schmidt Acked-by: Eilon Greenstein Signed-off-by: David S. Miller --- diff --git a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c index 2545213..00ff62f 100644 --- a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c +++ b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c @@ -10901,6 +10901,7 @@ init_ops_alloc_err: kfree(bp->init_data); request_firmware_exit: release_firmware(bp->firmware); + bp->firmware = NULL; return rc; }