From: Ben Adams Date: Mon, 20 Aug 2018 16:30:37 +0000 (+0100) Subject: Mark some readonly fields readonly (dotnet/coreclr#19559) X-Git-Tag: submit/tizen/20210909.063632~11030^2~4103 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=11edd362bd2de1ce29225695fbc6027bc0e06ee8;p=platform%2Fupstream%2Fdotnet%2Fruntime.git Mark some readonly fields readonly (dotnet/coreclr#19559) Commit migrated from https://github.com/dotnet/coreclr/commit/1f1d43abf34ba27e86ff4150d6970e7d1fda98d0 --- diff --git a/src/libraries/System.Private.CoreLib/src/System/Collections/Generic/Dictionary.cs b/src/libraries/System.Private.CoreLib/src/System/Collections/Generic/Dictionary.cs index 69363d6..bc30407 100644 --- a/src/libraries/System.Private.CoreLib/src/System/Collections/Generic/Dictionary.cs +++ b/src/libraries/System.Private.CoreLib/src/System/Collections/Generic/Dictionary.cs @@ -1157,11 +1157,11 @@ namespace System.Collections.Generic public struct Enumerator : IEnumerator>, IDictionaryEnumerator { - private Dictionary _dictionary; - private int _version; + private readonly Dictionary _dictionary; + private readonly int _version; private int _index; private KeyValuePair _current; - private int _getEnumeratorRetType; // What should Enumerator.Current return? + private readonly int _getEnumeratorRetType; // What should Enumerator.Current return? internal const int DictEntry = 1; internal const int KeyValuePair = 2; @@ -1392,9 +1392,9 @@ namespace System.Collections.Generic public struct Enumerator : IEnumerator, IEnumerator { - private Dictionary _dictionary; + private readonly Dictionary _dictionary; private int _index; - private int _version; + private readonly int _version; private TKey _currentKey; internal Enumerator(Dictionary dictionary) @@ -1575,9 +1575,9 @@ namespace System.Collections.Generic public struct Enumerator : IEnumerator, IEnumerator { - private Dictionary _dictionary; + private readonly Dictionary _dictionary; private int _index; - private int _version; + private readonly int _version; private TValue _currentValue; internal Enumerator(Dictionary dictionary) diff --git a/src/libraries/System.Private.CoreLib/src/System/Collections/Generic/List.cs b/src/libraries/System.Private.CoreLib/src/System/Collections/Generic/List.cs index 8d6d25b..698abe9 100644 --- a/src/libraries/System.Private.CoreLib/src/System/Collections/Generic/List.cs +++ b/src/libraries/System.Private.CoreLib/src/System/Collections/Generic/List.cs @@ -1116,9 +1116,9 @@ namespace System.Collections.Generic public struct Enumerator : IEnumerator, IEnumerator { - private List _list; + private readonly List _list; private int _index; - private int _version; + private readonly int _version; private T _current; internal Enumerator(List list)