From: Rafael J. Wysocki Date: Mon, 29 Dec 2008 18:19:07 +0000 (+0100) Subject: ACPI: Do not modify SCI_EN directly X-Git-Tag: v3.12-rc1~16332^2~4^2~3 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=11e93130c7ce5228d484fd5e86f3984835d4256b;p=kernel%2Fkernel-generic.git ACPI: Do not modify SCI_EN directly According to the ACPI specification the SCI_EN flag is controlled by the hardware, which sets this flag to inform the kernel that ACPI is enabled. For this reason, we shouldn't try to modify SCI_EN directly. Also, we don't need to do it in irqrouter_resume(), since lower-level resume code takes care of enabling ACPI in case it hasn't been enabled by the BIOS before passing control to the kernel (which by the way is against the ACPI specification). Signed-off-by: Rafael J. Wysocki Signed-off-by: Len Brown --- diff --git a/drivers/acpi/pci_link.c b/drivers/acpi/pci_link.c index e52ad91..e33c0bc 100644 --- a/drivers/acpi/pci_link.c +++ b/drivers/acpi/pci_link.c @@ -796,10 +796,6 @@ static int irqrouter_resume(struct sys_device *dev) struct list_head *node = NULL; struct acpi_pci_link *link = NULL; - - /* Make sure SCI is enabled again (Apple firmware bug?) */ - acpi_set_register(ACPI_BITREG_SCI_ENABLE, 1); - list_for_each(node, &acpi_link.entries) { link = list_entry(node, struct acpi_pci_link, node); if (!link) {