From: Alin Tomescu Date: Thu, 21 Feb 2013 02:36:09 +0000 (-0500) Subject: ppc: fix bamboo >256MB RAM initialization in hw/ppc4xx_devs.c X-Git-Tag: TizenStudio_2.0_p2.3.2~208^2~2500^2~1 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=11e5d738a4c68cd20e90477fa8b7ee873bf3e2c0;p=sdk%2Femulator%2Fqemu.git ppc: fix bamboo >256MB RAM initialization in hw/ppc4xx_devs.c I was trying to launch a PowerPC "bamboo" machine with more than 256MB of RAM with qemu-system-ppc -M bamboo -kernel $kernel -initrd $ramdisk -m 512, but QEMU would just hang. However, when I used -m 256, the machine would boot. I looked through the code in hw/ and it seems there is an error when the RAM memory is setup (if my understanding is correct). After patching it, the machine launched and booted successfully with 512MB of RAM. Signed-off-by: Alin Tomescu Signed-off-by: Stefan Hajnoczi --- diff --git a/hw/ppc4xx_devs.c b/hw/ppc4xx_devs.c index 5e491bc..b6bb0e1 100644 --- a/hw/ppc4xx_devs.c +++ b/hw/ppc4xx_devs.c @@ -700,7 +700,7 @@ ram_addr_t ppc4xx_sdram_adjust(ram_addr_t ram_size, int nr_banks, vmstate_register_ram_global(&ram_memories[i]); ram_bases[i] = base; ram_sizes[i] = bank_size; - base += ram_size; + base += bank_size; size_left -= bank_size; break; }