From: Theodore Ts'o <tytso@mit.edu>
Date: Tue, 6 Nov 2018 22:18:17 +0000 (-0500)
Subject: ext4: avoid possible double brelse() in add_new_gdb() on error path
X-Git-Tag: v4.9.138~23
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=11a2eb02e6d1efa664b2b52e9da5e2b6c8f28eb4;p=platform%2Fkernel%2Flinux-amlogic.git

ext4: avoid possible double brelse() in add_new_gdb() on error path

commit 4f32c38b4662312dd3c5f113d8bdd459887fb773 upstream.

Fixes: b40971426a83 ("ext4: add error checking to calls to ...")
Reported-by: Vasily Averin <vvs@virtuozzo.com>
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
Cc: stable@kernel.org # 2.6.38
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---

diff --git a/fs/ext4/resize.c b/fs/ext4/resize.c
index 76c3880eeff6..9be605c63ae1 100644
--- a/fs/ext4/resize.c
+++ b/fs/ext4/resize.c
@@ -844,6 +844,7 @@ static int add_new_gdb(handle_t *handle, struct inode *inode,
 	err = ext4_handle_dirty_metadata(handle, NULL, gdb_bh);
 	if (unlikely(err)) {
 		ext4_std_error(sb, err);
+		iloc.bh = NULL;
 		goto exit_inode;
 	}
 	brelse(dind);