From: Julien Isorce Date: Wed, 30 Nov 2016 09:22:17 +0000 (+0000) Subject: gstglcontext: is_shared should return FALSE if no group X-Git-Tag: 1.12.2~512 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=119955bea4acd1660b6a2403c956b686ac0d2d14;p=platform%2Fupstream%2Fgst-plugins-bad.git gstglcontext: is_shared should return FALSE if no group If a sub class of GstGLContext does not create a group then it currently crashes: 0 g_atomic_int_get (&share->refcount) 1 _context_share_group_is_shared (context->priv->sharegroup) 2 gst_gl_context_is_shared 3 _default_set_sync_gl https://bugzilla.gnome.org/show_bug.cgi?id=774518 --- diff --git a/gst-libs/gst/gl/gstglcontext.c b/gst-libs/gst/gl/gstglcontext.c index 899c121c5..792aac726 100644 --- a/gst-libs/gst/gl/gstglcontext.c +++ b/gst-libs/gst/gl/gstglcontext.c @@ -1670,6 +1670,10 @@ gboolean gst_gl_context_is_shared (GstGLContext * context) { g_return_val_if_fail (GST_IS_GL_CONTEXT (context), FALSE); + + if (!context->priv->sharegroup) + return FALSE; + if (GST_IS_GL_WRAPPED_CONTEXT (context)) g_return_val_if_fail (context->priv->active_thread, FALSE); else