From: Dinghao Liu <dinghao.liu@zju.edu.cn>
Date: Sat, 23 May 2020 12:47:58 +0000 (+0800)
Subject: spi: tegra20-sflash: Fix runtime PM imbalance on error
X-Git-Tag: v5.15~3374^2~29
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=117858bd63fb2ebcdfcc27b09fd65cb44511ea4c;p=platform%2Fkernel%2Flinux-starfive.git

spi: tegra20-sflash: Fix runtime PM imbalance on error

pm_runtime_get_sync() increments the runtime PM usage counter even
when it returns an error code. Thus a pairing decrement is needed on
the error handling path to keep the counter balanced.

Signed-off-by: Dinghao Liu <dinghao.liu@zju.edu.cn>
Link: https://lore.kernel.org/r/20200523124758.28604-1-dinghao.liu@zju.edu.cn
Signed-off-by: Mark Brown <broonie@kernel.org>
---

diff --git a/drivers/spi/spi-tegra20-sflash.c b/drivers/spi/spi-tegra20-sflash.c
index 5144293..02cf5f4 100644
--- a/drivers/spi/spi-tegra20-sflash.c
+++ b/drivers/spi/spi-tegra20-sflash.c
@@ -491,6 +491,7 @@ static int tegra_sflash_probe(struct platform_device *pdev)
 	ret = pm_runtime_get_sync(&pdev->dev);
 	if (ret < 0) {
 		dev_err(&pdev->dev, "pm runtime get failed, e = %d\n", ret);
+		pm_runtime_put_noidle(&pdev->dev);
 		goto exit_pm_disable;
 	}