From: Diego 'Flameeyes' Pettenò <flameeyes@gentoo.org>
Date: Thu, 23 Nov 2006 14:15:30 +0000 (+0100)
Subject: Avoid race condition when using multiple make jobs
X-Git-Tag: 1.8.1~178
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=11738b2af0d8bfcf5b2f7c0d3e6ade1a14866b94;p=profile%2Fivi%2Flibxcb.git

Avoid race condition when using multiple make jobs

Avoid race condition when symlinking XML files.
When declaring a rule with many files as target, the rule is called
when any of them is requested, resulting in multiple for loops happening
during a make process using more than one job.
Also, use '$(LN_S) -f' rather than removing and recreating a file,
that one should be as supported as 'rm -f' and requires one less command.
---

diff --git a/src/Makefile.am b/src/Makefile.am
index fdbd6b4..b02caf3 100644
--- a/src/Makefile.am
+++ b/src/Makefile.am
@@ -220,7 +220,4 @@ SUFFIXES = .xml
 	            -o $@ $(srcdir)/c-client.xsl $< 
 
 $(EXTENSION_XML):
-	for i in $(EXTENSION_XML) ; do \
-           rm -f $$i ; \
-           $(LN_S) $(XCBPROTO_XCBINCLUDEDIR)/$$i $$i ; \
-        done
+	$(LN_S) -f $(XCBPROTO_XCBINCLUDEDIR)/$@ $@