From: Ben Skeggs <bskeggs@redhat.com>
Date: Thu, 23 Jan 2014 00:49:47 +0000 (+1000)
Subject: drm/nouveau: call drm_vblank_cleanup() earlier
X-Git-Tag: v4.0~2300^2~8^2~14
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=1139ffb96b3f4e8be9006552d2dd4d302d62c2ee;p=platform%2Fkernel%2Flinux-amlogic.git

drm/nouveau: call drm_vblank_cleanup() earlier

Fixes a NULL-ptr deref seen on module unload sometimes.

Signed-off-by: Ben Skeggs <bskeggs@redhat.com>
---

diff --git a/drivers/gpu/drm/nouveau/nouveau_display.c b/drivers/gpu/drm/nouveau/nouveau_display.c
index a22d019..b4262ad 100644
--- a/drivers/gpu/drm/nouveau/nouveau_display.c
+++ b/drivers/gpu/drm/nouveau/nouveau_display.c
@@ -74,14 +74,14 @@ nouveau_display_vblank_fini(struct drm_device *dev)
 	struct nouveau_display *disp = nouveau_display(dev);
 	int i;
 
+	drm_vblank_cleanup(dev);
+
 	if (disp->vblank) {
 		for (i = 0; i < dev->mode_config.num_crtc; i++)
 			nouveau_event_ref(NULL, &disp->vblank[i]);
 		kfree(disp->vblank);
 		disp->vblank = NULL;
 	}
-
-	drm_vblank_cleanup(dev);
 }
 
 static int