From: Vineeth T M Date: Mon, 20 Oct 2014 06:27:38 +0000 (+0530) Subject: videobox: critical error when element properties set as max/min X-Git-Tag: 1.19.3~509^2~4116 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=1131db8c1f6b096dfa9737e2fb3cc7f904104b1b;p=platform%2Fupstream%2Fgstreamer.git videobox: critical error when element properties set as max/min left, right, top, bottom can be set from range of -2147483648 to 2147483647 when i launch the videobox element with that values, it gives a critical error (gst-check-1.0:29869): GStreamer-CRITICAL **: gst_value_set_int_range_step: assertion 'start < end' failed This happens because min cannot be equal to max. https://bugzilla.gnome.org/show_bug.cgi?id=738838 --- diff --git a/gst/videobox/gstvideobox.c b/gst/videobox/gstvideobox.c index d09a981..4c0ed36 100644 --- a/gst/videobox/gstvideobox.c +++ b/gst/videobox/gstvideobox.c @@ -2746,7 +2746,7 @@ gst_video_box_transform_dimension_value (const GValue * src_val, min = gst_video_box_transform_dimension (min, delta); max = gst_video_box_transform_dimension (max, delta); - if (min > max) { + if (min >= max) { ret = FALSE; g_value_unset (dest_val); } else {