From: Dan Carpenter <dan.carpenter@oracle.com>
Date: Tue, 7 Apr 2020 09:30:28 +0000 (+0300)
Subject: tee: remove unnecessary NULL check in tee_shm_alloc()
X-Git-Tag: v5.10.7~2442^2~20^2
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=1115899e7aad71bc36100c3fa1d0b99cff9263e6;p=platform%2Fkernel%2Flinux-rpi.git

tee: remove unnecessary NULL check in tee_shm_alloc()

Smatch complains that "ctx" isn't checked consistently:

    drivers/tee/tee_shm.c:164 tee_shm_alloc()
    warn: variable dereferenced before check 'ctx' (see line 95)

I audited the callers and "ctx" can't be NULL so the check can be
removed.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Jens Wiklander <jens.wiklander@linaro.org>
---

diff --git a/drivers/tee/tee_shm.c b/drivers/tee/tee_shm.c
index bd679b7..8895cb9 100644
--- a/drivers/tee/tee_shm.c
+++ b/drivers/tee/tee_shm.c
@@ -161,8 +161,7 @@ struct tee_shm *tee_shm_alloc(struct tee_context *ctx, size_t size, u32 flags)
 		}
 	}
 
-	if (ctx)
-		teedev_ctx_get(ctx);
+	teedev_ctx_get(ctx);
 
 	return shm;
 err_rem: