From: Donglin Peng Date: Sun, 20 Aug 2017 05:21:35 +0000 (+0800) Subject: ASoC: s3c24xx_uda134x: Remove unnecessary function call X-Git-Tag: v4.15-rc1~18^2~13^2~2^2~4 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=1107a293b7c33723ace2a8d18f5c6febcd576d7a;p=platform%2Fkernel%2Flinux-exynos.git ASoC: s3c24xx_uda134x: Remove unnecessary function call First of all,the address of pdev->dev is assigned to card->dev,then the function platform_set_drvdata copies the value the variable card to pdev->dev.driver_data, but when calling snd_soc_register_card,the function dev_set_drvdata(card->dev, card) will also do the same copy operation,so i think that the former copy operation can be removed. Signed-off-by: Peng Donglin Signed-off-by: Mark Brown --- diff --git a/sound/soc/samsung/s3c24xx_uda134x.c b/sound/soc/samsung/s3c24xx_uda134x.c index c65c89d..5fb3bab 100644 --- a/sound/soc/samsung/s3c24xx_uda134x.c +++ b/sound/soc/samsung/s3c24xx_uda134x.c @@ -237,7 +237,6 @@ static int s3c24xx_uda134x_probe(struct platform_device *pdev) mutex_init(&priv->clk_lock); card->dev = &pdev->dev; - platform_set_drvdata(pdev, card); snd_soc_card_set_drvdata(card, priv); ret = devm_snd_soc_register_card(&pdev->dev, card);