From: Luis Chamberlain Date: Wed, 18 Aug 2021 14:45:42 +0000 (+0200) Subject: null_blk: add error handling support for add_disk() X-Git-Tag: v5.15~460^2~14 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=10e7123d5551dec0025f70e61604ab57483a6ed2;p=platform%2Fkernel%2Flinux-starfive.git null_blk: add error handling support for add_disk() We never checked for errors on add_disk() as this function returned void. Now that this is fixed, use the shiny new error handling. The actual cleanup in case of error is already handled by the caller of null_gendisk_register(). Signed-off-by: Luis Chamberlain Signed-off-by: Christoph Hellwig Reviewed-by: Hannes Reinecke Link: https://lore.kernel.org/r/20210818144542.19305-12-hch@lst.de Signed-off-by: Jens Axboe --- diff --git a/drivers/block/null_blk/main.c b/drivers/block/null_blk/main.c index f128242..187d779 100644 --- a/drivers/block/null_blk/main.c +++ b/drivers/block/null_blk/main.c @@ -1717,8 +1717,7 @@ static int null_gendisk_register(struct nullb *nullb) return ret; } - add_disk(disk); - return 0; + return add_disk(disk); } static int null_init_tag_set(struct nullb *nullb, struct blk_mq_tag_set *set)