From: Junyeon LEE Date: Thu, 6 Apr 2017 08:12:22 +0000 (+0900) Subject: net/tls: fix log flooding and data aborts X-Git-Tag: 1.1_Public_Release~614^2~135 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=10c020f0e5f2e780be65fe20d59c52a2a84993f6;p=rtos%2Ftinyara.git net/tls: fix log flooding and data aborts This commit fixes two minor tls issues: . Log flooding when CONFIG_HW_DH_PARAM is enabled . Data abort at security APIs when called before see_init() Change-Id: Ied77bc66adc732b21c472a9005fb28fe3eb421e3 Signed-off-by: Junyeon LEE --- diff --git a/os/net/tls/see_api.c b/os/net/tls/see_api.c index 1deda83..457d0ad 100644 --- a/os/net/tls/see_api.c +++ b/os/net/tls/see_api.c @@ -306,10 +306,14 @@ int see_mutex_free(see_mutex_t *m) int see_mutex_lock(see_mutex_t *m) { - if (m == NULL || !m->valid) { + if (m == NULL) { return -1; } + if (!m->valid) { + see_init(); + } + if (pthread_mutex_lock(&m->mutex) != 0) { return -1; } diff --git a/os/net/tls/ssl_srv.c b/os/net/tls/ssl_srv.c index 9831e66..d53c5a3 100644 --- a/os/net/tls/ssl_srv.c +++ b/os/net/tls/ssl_srv.c @@ -2485,7 +2485,9 @@ static int ssl_write_server_key_exchange(mbedtls_ssl_context *ssl) p += len; n += len; +#if !defined(CONFIG_HW_DH_PARAM) MBEDTLS_SSL_DEBUG_MPI(3, "DHM: X ", &ssl->handshake->dhm_ctx.X); +#endif MBEDTLS_SSL_DEBUG_MPI(3, "DHM: P ", &ssl->handshake->dhm_ctx.P); MBEDTLS_SSL_DEBUG_MPI(3, "DHM: G ", &ssl->handshake->dhm_ctx.G); MBEDTLS_SSL_DEBUG_MPI(3, "DHM: GX", &ssl->handshake->dhm_ctx.GX);