From: Hans de Goede Date: Wed, 9 Mar 2022 17:05:32 +0000 (+0100) Subject: platform/x86: thinkpad_acpi: Don't use test_bit on an integer X-Git-Tag: v6.1-rc5~1728^2~14 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=10b29dd7eafe1987b44866d3ee1d0d71bf622cb3;p=platform%2Fkernel%2Flinux-starfive.git platform/x86: thinkpad_acpi: Don't use test_bit on an integer test_bit can only be used on longs not on ints, fix this. Reported-by: Stephen Rothwell Signed-off-by: Hans de Goede Link: https://lore.kernel.org/r/20220309170532.343384-2-hdegoede@redhat.com --- diff --git a/drivers/platform/x86/thinkpad_acpi.c b/drivers/platform/x86/thinkpad_acpi.c index 7016c7f..c476a785 100644 --- a/drivers/platform/x86/thinkpad_acpi.c +++ b/drivers/platform/x86/thinkpad_acpi.c @@ -10399,7 +10399,7 @@ static int tpacpi_dytc_profile_init(struct ibm_init_struct *iibm) if (err) return err; - if (test_bit(DYTC_FC_MMC, (void *)&output)) { /* MMC MODE */ + if (output & BIT(DYTC_FC_MMC)) { /* MMC MODE */ dytc_profile_available = DYTC_FUNCMODE_MMC; /* @@ -10412,7 +10412,7 @@ static int tpacpi_dytc_profile_init(struct ibm_init_struct *iibm) if (!err && ((output & DYTC_ERR_MASK) == DYTC_ERR_SUCCESS)) dytc_mmc_get_available = true; } - } else if (test_bit(DYTC_FC_PSC, (void *)&output)) { /*PSC MODE */ + } else if (output & BIT(DYTC_FC_PSC)) { /* PSC MODE */ dytc_profile_available = DYTC_FUNCMODE_PSC; } else { dbg_printk(TPACPI_DBG_INIT, "No DYTC support available\n");