From: Mike Snitzer Date: Fri, 6 Jan 2017 20:38:08 +0000 (-0500) Subject: dm raid: cleanup awkward branching in raid_message() option processing X-Git-Tag: v5.15~11752^2~19 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=105db5991240cb2675f193589130ef0c8a4f70fe;p=platform%2Fkernel%2Flinux-starfive.git dm raid: cleanup awkward branching in raid_message() option processing Signed-off-by: Mike Snitzer --- diff --git a/drivers/md/dm-raid.c b/drivers/md/dm-raid.c index 34442c6..5c9e95d 100644 --- a/drivers/md/dm-raid.c +++ b/drivers/md/dm-raid.c @@ -3464,10 +3464,11 @@ static int raid_message(struct dm_target *ti, unsigned int argc, char **argv) else { if (!strcasecmp(argv[0], "check")) set_bit(MD_RECOVERY_CHECK, &mddev->recovery); - else if (!!strcasecmp(argv[0], "repair")) + else if (!strcasecmp(argv[0], "repair")) { + set_bit(MD_RECOVERY_REQUESTED, &mddev->recovery); + set_bit(MD_RECOVERY_SYNC, &mddev->recovery); + } else return -EINVAL; - set_bit(MD_RECOVERY_REQUESTED, &mddev->recovery); - set_bit(MD_RECOVERY_SYNC, &mddev->recovery); } if (mddev->ro == 2) { /* A write to sync_action is enough to justify