From: J. Bruce Fields Date: Sat, 22 Dec 2012 00:48:59 +0000 (-0500) Subject: Revert "nfsd: warn on odd reply state in nfsd_vfs_read" X-Git-Tag: v3.8-rc1~4 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=10532b560bacf23766f9c7dc09778b31b198ff45;p=profile%2Fivi%2Fkernel-adaptation-intel-automotive.git Revert "nfsd: warn on odd reply state in nfsd_vfs_read" This reverts commit 79f77bf9a4e3dd5ead006b8f17e7c4ff07d8374e. This is obviously wrong, and I have no idea how I missed seeing the warning in testing: I must just not have looked at the right logs. The caller bumps rq_resused/rq_next_page, so it will always be hit on a large enough read. Reported-by: Dave Jones Signed-off-by: J. Bruce Fields Signed-off-by: Linus Torvalds --- diff --git a/fs/nfsd/vfs.c b/fs/nfsd/vfs.c index f0a6d88..d586117 100644 --- a/fs/nfsd/vfs.c +++ b/fs/nfsd/vfs.c @@ -934,7 +934,6 @@ nfsd_vfs_read(struct svc_rqst *rqstp, struct svc_fh *fhp, struct file *file, .u.data = rqstp, }; - WARN_ON_ONCE(rqstp->rq_next_page != rqstp->rq_respages + 1); rqstp->rq_next_page = rqstp->rq_respages + 1; host_err = splice_direct_to_actor(file, &sd, nfsd_direct_splice_actor); } else {