From: Thierry Boureille <thierry.boureille@gmail.com>
Date: Thu, 28 Jul 2011 00:35:05 +0000 (+0200)
Subject: service : Fix put data on null pointer
X-Git-Tag: 0.77~72
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=10520d0b86c6eb022785f046801b577c8877ea38;p=platform%2Fupstream%2Fconnman.git

service : Fix put data on null pointer

when using ConnectService of Manager interface a segfault arises due
to a null pointer.

in __connman_service_create_and_connect:

	[...]
	service = lookup_by_identifier(name);

	if (service != NULL)
		goto done;

	network = create_hidden_wifi(device, ssid, mode, security);
	if (network != NULL) {
		connman_network_set_group(network, group);
		service->network_created = TRUE;
	}
	[...]
in this part "service" is null
---

diff --git a/src/service.c b/src/service.c
index d442c16..1939832 100644
--- a/src/service.c
+++ b/src/service.c
@@ -4206,10 +4206,8 @@ int __connman_service_create_and_connect(DBusMessage *msg)
 		goto done;
 
 	network = create_hidden_wifi(device, ssid, mode, security);
-	if (network != NULL) {
+	if (network != NULL)
 		connman_network_set_group(network, group);
-		service->network_created = TRUE;
-	}
 
 	service = lookup_by_identifier(name);
 
@@ -4222,6 +4220,8 @@ done:
 		goto failed;
 	}
 
+	service->network_created = TRUE;
+
 	if (is_connected(service) == TRUE) {
 		err = -EISCONN;
 		goto failed;