From: Francois Romieu Date: Thu, 16 Feb 2006 21:17:00 +0000 (+0100) Subject: sis190: early setting of the pci driver private data X-Git-Tag: v3.12-rc1~38365^2~9^2 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=10487fbd74f2f9c9b5fb2d77efd50eab48db191a;p=kernel%2Fkernel-generic.git sis190: early setting of the pci driver private data Below this point, the error path will proceed through sis190_release_board(). It will happily oops if pci_set_drvdata() has not been issued. Signed-off-by: Francois Romieu --- diff --git a/drivers/net/sis190.c b/drivers/net/sis190.c index b420182..ed4bc91 100644 --- a/drivers/net/sis190.c +++ b/drivers/net/sis190.c @@ -1791,6 +1791,8 @@ static int __devinit sis190_init_one(struct pci_dev *pdev, goto out; } + pci_set_drvdata(pdev, dev); + tp = netdev_priv(dev); ioaddr = tp->mmio_addr; @@ -1827,8 +1829,6 @@ static int __devinit sis190_init_one(struct pci_dev *pdev, if (rc < 0) goto err_remove_mii; - pci_set_drvdata(pdev, dev); - net_probe(tp, KERN_INFO "%s: %s at %p (IRQ: %d), " "%2.2x:%2.2x:%2.2x:%2.2x:%2.2x:%2.2x\n", pci_name(pdev), sis_chip_info[ent->driver_data].name,