From: Samuel Thibault Date: Thu, 10 May 2012 22:31:37 +0000 (-0700) Subject: Hurd: Fix sbrk beyond 128MB X-Git-Tag: upstream/2.30~11027 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=1043890b10996ec4b14cd01040b82610760d5d4a;p=external%2Fglibc.git Hurd: Fix sbrk beyond 128MB --- diff --git a/ChangeLog b/ChangeLog index ac0ad18..11fdd81 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,10 @@ +2012-05-10 Samuel Thibault + + * sysdeps/mach/hurd/brk.c (_hurd_set_brk): When more space needs to be + allocated, call __vm_protect to finish enabling the existing space, and + pass a copy of _hurd_data_end instead of PAGEBRK to __vm_allocate to + allocate the remainder. + 2012-05-10 Pino Toscano * sysdeps/mach/hurd/recvfrom.c (__recvfrom): Check also for a null diff --git a/sysdeps/mach/hurd/brk.c b/sysdeps/mach/hurd/brk.c index 275d7be..1900277 100644 --- a/sysdeps/mach/hurd/brk.c +++ b/sysdeps/mach/hurd/brk.c @@ -1,4 +1,4 @@ -/* Copyright (C) 1991,92,93,94,95,96,97,99,2000 Free Software Foundation, Inc. +/* Copyright (C) 1991-2012 Free Software Foundation, Inc. This file is part of the GNU C Library. The GNU C Library is free software; you can redistribute it and/or @@ -63,7 +63,7 @@ weak_alias (__brk, brk) int _hurd_set_brk (vm_address_t addr) { - error_t err; + error_t err = 0; vm_address_t pagend = round_page (addr); vm_address_t pagebrk = round_page (_hurd_brk); long int rlimit; @@ -100,8 +100,22 @@ _hurd_set_brk (vm_address_t addr) if (pagend > _hurd_data_end) { + vm_address_t alloc_start = _hurd_data_end; + /* We didn't allocate enough space! Hopefully we can get some more! */ - err = __vm_allocate (__mach_task_self (), &pagebrk, pagend - pagebrk, 0); + + if (_hurd_data_end > pagebrk) + /* First finish allocation. */ + err = __vm_protect (__mach_task_self (), pagebrk, + alloc_start - pagebrk, 0, + VM_PROT_READ|VM_PROT_WRITE|VM_PROT_EXECUTE); + if (! err) + _hurd_brk = alloc_start; + + if (! err) + err = __vm_allocate (__mach_task_self (), &alloc_start, + pagend - alloc_start, 0); + if (! err) _hurd_data_end = pagend; }