From: Neil Armstrong <narmstrong@baylibre.com>
Date: Tue, 6 Oct 2015 14:39:53 +0000 (+0100)
Subject: net: dsa: add missing kfree on remove
X-Git-Tag: v4.3-rc7~23^2~35^2~4
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=1023d2ec1e8bd63ede9ed1d93ebb797f650859b7;p=platform%2Fkernel%2Flinux-exynos.git

net: dsa: add missing kfree on remove

To prevent memory leakage on unbinding, add missing kfree calls.
Includes minor cosmetic change to make patch clean.

Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
---

diff --git a/net/dsa/dsa.c b/net/dsa/dsa.c
index c59fa5d..ed9d43f 100644
--- a/net/dsa/dsa.c
+++ b/net/dsa/dsa.c
@@ -914,8 +914,10 @@ static void dsa_remove_dst(struct dsa_switch_tree *dst)
 	for (i = 0; i < dst->pd->nr_chips; i++) {
 		struct dsa_switch *ds = dst->ds[i];
 
-		if (ds != NULL)
+		if (ds) {
 			dsa_switch_destroy(ds);
+			kfree(ds);
+		}
 	}
 }
 
@@ -924,6 +926,7 @@ static int dsa_remove(struct platform_device *pdev)
 	struct dsa_switch_tree *dst = platform_get_drvdata(pdev);
 
 	dsa_remove_dst(dst);
+	kfree(dst);
 	dsa_of_remove(&pdev->dev);
 
 	return 0;