From: Amitoj Kaur Chawla Date: Thu, 27 Jul 2017 03:19:07 +0000 (-0400) Subject: staging: greybus: Remove unnecessary platform_set_drvdata X-Git-Tag: v5.15~10534^2~361 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=100330ecc465477e882181e17dd3bb09ac14ae51;p=platform%2Fkernel%2Flinux-starfive.git staging: greybus: Remove unnecessary platform_set_drvdata Unnecessary platform_set_drvdata() has been removed since the driver core clears the driver data to NULL after device release or on probe failure. There is no need to manually clear the device driver data to NULL. The Coccinelle semantic patch used to make this change is as follows: // @@ struct platform_device *pdev; @@ - platform_set_drvdata(pdev, NULL); // Signed-off-by: Amitoj Kaur Chawla Acked-by: Viresh Kumar Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/staging/greybus/arche-platform.c b/drivers/staging/greybus/arche-platform.c index 62599040..4837aca 100644 --- a/drivers/staging/greybus/arche-platform.c +++ b/drivers/staging/greybus/arche-platform.c @@ -610,7 +610,6 @@ static int arche_platform_remove(struct platform_device *pdev) device_remove_file(&pdev->dev, &dev_attr_state); device_for_each_child(&pdev->dev, NULL, arche_remove_child); arche_platform_poweroff_seq(arche_pdata); - platform_set_drvdata(pdev, NULL); if (usb3613_hub_mode_ctrl(false)) dev_warn(arche_pdata->dev, "failed to control hub device\n");