From: dglazkov@chromium.org Date: Thu, 29 Sep 2011 01:03:30 +0000 (+0000) Subject: garden-o-matic results should anticipate 0 unexpected failures. X-Git-Tag: 070512121124~23407 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=0fdcf00b6004134603eb0f071aa99576e6eb00e1;p=profile%2Fivi%2Fwebkit-efl.git garden-o-matic results should anticipate 0 unexpected failures. https://bugs.webkit.org/show_bug.cgi?id=69036 Also fixes controllers: UnexpectedFailures test. Reviewed by Adam Barth. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js: Tweaked. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96282 268f45cc-cd09-0410-ab3c-d52691b4dbfc --- diff --git a/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js b/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js index c8e58a1..20d5d79 100644 --- a/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js +++ b/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js @@ -228,7 +228,8 @@ ui.results.TestSelector = base.extends('div', { firstResult: function() { $(this).accordion('option', 'active', 0); - $('.builder-selector', this)[0].firstResult(); + var builderSelector = $('.builder-selector', this)[0]; + builderSelector && builderSelector.firstResult(); }, currentTestName: function() { diff --git a/Tools/ChangeLog b/Tools/ChangeLog index 99e09a3..3cb3ba0 100644 --- a/Tools/ChangeLog +++ b/Tools/ChangeLog @@ -1,3 +1,14 @@ +2011-09-28 Dimitri Glazkov + + garden-o-matic results should anticipate 0 unexpected failures. + https://bugs.webkit.org/show_bug.cgi?id=69036 + + Also fixes controllers: UnexpectedFailures test. + + Reviewed by Adam Barth. + + * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js: Tweaked. + 2011-09-28 Dirk Pranke Modify new-run-webkit-tests to return the percentage difference in image diffs where possible.