From: Mark Brown <broonie@opensource.wolfsonmicro.com>
Date: Mon, 2 Jul 2012 13:26:15 +0000 (+0100)
Subject: mmc: sdhci: Report failure reasons for all cases in sdhci_add_host()
X-Git-Tag: v3.6-rc1~153^2~18
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=0fc81ee3102efedd4571e28372d2242c694c67ec;p=platform%2Fkernel%2Flinux-3.10.git

mmc: sdhci: Report failure reasons for all cases in sdhci_add_host()

For most error conditions sdhci_add_host() will print a diagnostic
message indicating why it failed but there are a few cases where this
does not happen. Add error messages in these cases to aid diagnosis.

Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
Signed-off-by: Chris Ball <cjb@laptop.org>
---

diff --git a/drivers/mmc/host/sdhci.c b/drivers/mmc/host/sdhci.c
index 206b52f..101f9d4 100644
--- a/drivers/mmc/host/sdhci.c
+++ b/drivers/mmc/host/sdhci.c
@@ -3033,8 +3033,11 @@ int sdhci_add_host(struct sdhci_host *host)
 
 	ret = request_irq(host->irq, sdhci_irq, IRQF_SHARED,
 		mmc_hostname(mmc), host);
-	if (ret)
+	if (ret) {
+		pr_err("%s: Failed to request IRQ %d: %d\n",
+		       mmc_hostname(mmc), host->irq, ret);
 		goto untasklet;
+	}
 
 	sdhci_init(host, 0);
 
@@ -3051,8 +3054,11 @@ int sdhci_add_host(struct sdhci_host *host)
 	host->led.brightness_set = sdhci_led_control;
 
 	ret = led_classdev_register(mmc_dev(mmc), &host->led);
-	if (ret)
+	if (ret) {
+		pr_err("%s: Failed to register LED device: %d\n",
+		       mmc_hostname(mmc), ret);
 		goto reset;
+	}
 #endif
 
 	mmiowb();