From: Takashi Sakamoto <o-takashi@sakamocchi.jp>
Date: Thu, 26 Apr 2018 13:00:29 +0000 (+0900)
Subject: ALSA: dice: fix error path to destroy initialized stream data
X-Git-Tag: v4.19~773^2~30
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=0f925660a7bc49b269c163249a5d06da3a0c7b0a;p=platform%2Fkernel%2Flinux-rpi3.git

ALSA: dice: fix error path to destroy initialized stream data

In error path of snd_dice_stream_init_duplex(), stream data for incoming
packet can be left to be initialized.

This commit fixes it.

Fixes: 436b5abe2224 ('ALSA: dice: handle whole available isochronous streams')
Cc: <stable@vger.kernel.org> # v4.6+
Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
---

diff --git a/sound/firewire/dice/dice-stream.c b/sound/firewire/dice/dice-stream.c
index 8573289..928a255 100644
--- a/sound/firewire/dice/dice-stream.c
+++ b/sound/firewire/dice/dice-stream.c
@@ -435,7 +435,7 @@ int snd_dice_stream_init_duplex(struct snd_dice *dice)
 		err = init_stream(dice, AMDTP_IN_STREAM, i);
 		if (err < 0) {
 			for (; i >= 0; i--)
-				destroy_stream(dice, AMDTP_OUT_STREAM, i);
+				destroy_stream(dice, AMDTP_IN_STREAM, i);
 			goto end;
 		}
 	}