From: Gao Xiang <hsiangkao@linux.alibaba.com>
Date: Fri, 2 Aug 2024 01:55:25 +0000 (+0800)
Subject: erofs-utils: fsck: fix fd leak on failure in erofs_extract_file()
X-Git-Tag: v1.8~13
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=0f8f48d9530b905ebb454fb646e1a1a453bc304b;p=platform%2Fupstream%2Ferofs-utils.git

erofs-utils: fsck: fix fd leak on failure in erofs_extract_file()

Ignore the return values as other close()s instead.

Coverity-id: 502331
Reviewed-by: Sandeep Dhavale <dhavale@google.com>
Signed-off-by: Gao Xiang <hsiangkao@linux.alibaba.com>
Link: https://lore.kernel.org/r/20240802015527.2113797-1-hsiangkao@linux.alibaba.com
---

diff --git a/fsck/main.c b/fsck/main.c
index fb66967..28f1e7e 100644
--- a/fsck/main.c
+++ b/fsck/main.c
@@ -702,11 +702,7 @@ again:
 
 	/* verify data chunk layout */
 	ret = erofs_verify_inode_data(inode, fd);
-	if (ret)
-		return ret;
-
-	if (close(fd))
-		return -errno;
+	close(fd);
 	return ret;
 }