From: Daniel Jasper Date: Wed, 13 Mar 2013 15:53:12 +0000 (+0000) Subject: Fix comment indentation before labels. X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=0f8ed9e4e117e5e65c01e5a07d50655798fd78d5;p=platform%2Fupstream%2Fllvm.git Fix comment indentation before labels. Before: switch (x) { // if 1, do f() case 1: f(); } After: switch (x) { // if 1, do f() case 1: f(); } llvm-svn: 176953 --- diff --git a/clang/lib/Format/Format.cpp b/clang/lib/Format/Format.cpp index 67ca928..63edc6e 100644 --- a/clang/lib/Format/Format.cpp +++ b/clang/lib/Format/Format.cpp @@ -1135,6 +1135,13 @@ public: deriveLocalStyle(); for (unsigned i = 0, e = AnnotatedLines.size(); i != e; ++i) { Annotator.calculateFormattingInformation(AnnotatedLines[i]); + + // Adapt level to the next line if this is a comment. + // FIXME: Can/should this be done in the UnwrappedLineParser? + if (i + 1 != e && AnnotatedLines[i].First.is(tok::comment) && + AnnotatedLines[i].First.Children.empty() && + AnnotatedLines[i + 1].First.isNot(tok::r_brace)) + AnnotatedLines[i].Level = AnnotatedLines[i + 1].Level; } std::vector IndentForLevel; bool PreviousLineWasTouched = false; diff --git a/clang/unittests/Format/FormatTest.cpp b/clang/unittests/Format/FormatTest.cpp index 79163a6..17aeaca 100644 --- a/clang/unittests/Format/FormatTest.cpp +++ b/clang/unittests/Format/FormatTest.cpp @@ -427,6 +427,11 @@ TEST_F(FormatTest, FormatsSwitchStatement) { "default: {\n" " // Do nothing.\n" "}"); + verifyFormat("switch (x) {\n" + "// if 1, do f()\n" + "case 1:\n" + " f();\n" + "}"); verifyGoogleFormat("switch (x) {\n" " case 1:\n"