From: Krzysztof Kozlowski <krzk@kernel.org>
Date: Wed, 26 Aug 2020 14:49:35 +0000 (+0200)
Subject: mfd: wcd934x: Simplify with dev_err_probe()
X-Git-Tag: v5.15~2680^2~18
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=0f1b1b899521e3380a01f9f88a1bcb6163b7ee9f;p=platform%2Fkernel%2Flinux-starfive.git

mfd: wcd934x: Simplify with dev_err_probe()

Common pattern of handling deferred probe can be simplified with
dev_err_probe().  Less code and also it prints the error value.

Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---

diff --git a/drivers/mfd/wcd934x.c b/drivers/mfd/wcd934x.c
index da91030..c274d73 100644
--- a/drivers/mfd/wcd934x.c
+++ b/drivers/mfd/wcd934x.c
@@ -219,12 +219,9 @@ static int wcd934x_slim_probe(struct slim_device *sdev)
 		return	-ENOMEM;
 
 	ddata->irq = of_irq_get(np, 0);
-	if (ddata->irq < 0) {
-		if (ddata->irq != -EPROBE_DEFER)
-			dev_err(ddata->dev, "Failed to get IRQ: err = %d\n",
-				ddata->irq);
-		return ddata->irq;
-	}
+	if (ddata->irq < 0)
+		return dev_err_probe(ddata->dev, ddata->irq,
+				     "Failed to get IRQ\n");
 
 	reset_gpio = of_get_named_gpio(np, "reset-gpios", 0);
 	if (reset_gpio < 0) {