From: Nathan Chancellor Date: Mon, 8 Oct 2018 22:11:28 +0000 (-0400) Subject: media: tc358743: Remove unnecessary self assignment X-Git-Tag: v5.4-rc1~2068^2~30 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=0ede1794b9667d9cd35d1ac27f2eeff52d5733d5;p=platform%2Fkernel%2Flinux-rpi.git media: tc358743: Remove unnecessary self assignment Clang warns when a variable is assigned to itself. drivers/media/i2c/tc358743.c:1921:7: warning: explicitly assigning value of variable of type 'int' to itself [-Wself-assign] ret = ret; ~~~ ^ ~~~ 1 warning generated. Signed-off-by: Nathan Chancellor Reviewed-by: Kieran Bingham Signed-off-by: Hans Verkuil Signed-off-by: Mauro Carvalho Chehab --- diff --git a/drivers/media/i2c/tc358743.c b/drivers/media/i2c/tc358743.c index ca5d929..41d470d 100644 --- a/drivers/media/i2c/tc358743.c +++ b/drivers/media/i2c/tc358743.c @@ -1918,7 +1918,6 @@ static int tc358743_probe_of(struct tc358743_state *state) ret = v4l2_fwnode_endpoint_alloc_parse(of_fwnode_handle(ep), &endpoint); if (ret) { dev_err(dev, "failed to parse endpoint\n"); - ret = ret; goto put_node; }