From: Andoni Morales Alastruey <amorales@flumotion.com>
Date: Mon, 14 Mar 2011 14:46:50 +0000 (+0100)
Subject: matroskamux: return TRUE from sink pad event function for tag events, which are handled
X-Git-Tag: RELEASE-0.10.29~525
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=0ed0174ea98923186112458512e5a026ac69716c;p=platform%2Fupstream%2Fgst-plugins-good.git

matroskamux: return TRUE from sink pad event function for tag events, which are handled

https://bugzilla.gnome.org/show_bug.cgi?id=644730
---

diff --git a/gst/matroska/matroska-mux.c b/gst/matroska/matroska-mux.c
index 31fe40b..b94a434 100644
--- a/gst/matroska/matroska-mux.c
+++ b/gst/matroska/matroska-mux.c
@@ -644,22 +644,23 @@ gst_matroska_mux_handle_sink_event (GstPad * pad, GstEvent * event)
       gst_tag_setter_merge_tags (GST_TAG_SETTER (mux), list,
           gst_tag_setter_get_tag_merge_mode (GST_TAG_SETTER (mux)));
 
-      /* handled this, don't want collectpads to forward it downstream */
-      ret = FALSE;
       gst_event_unref (event);
+      /* handled this, don't want collectpads to forward it downstream */
+      event = NULL;
       break;
     }
     case GST_EVENT_NEWSEGMENT:
       /* We don't support NEWSEGMENT events */
       ret = FALSE;
       gst_event_unref (event);
+      event = NULL;
       break;
     default:
       break;
   }
 
   /* now GstCollectPads can take care of the rest, e.g. EOS */
-  if (ret)
+  if (event)
     ret = mux->collect_event (pad, event);
 
   gst_object_unref (mux);