From: Jim Meyering <jim@meyering.net>
Date: Mon, 2 Sep 2002 07:38:53 +0000 (+0000)
Subject: (skip): Add casts to avoid warning about comparison
X-Git-Tag: COREUTILS-4_5_2~208
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=0ea01d21a34447f456ce340bad52f4629cb8d73d;p=platform%2Fupstream%2Fcoreutils.git

(skip): Add casts to avoid warning about comparison
between signed and unsigned. Also rearrange range-checking
comparisons to make them more readable.
---

diff --git a/src/install.c b/src/install.c
index 3be52b0..7e0d8ed 100644
--- a/src/install.c
+++ b/src/install.c
@@ -560,7 +560,7 @@ get_ids (void)
 	{
 	  long int tmp_long;
 	  if (xstrtol (owner_name, NULL, 0, &tmp_long, NULL) != LONGINT_OK
-	      || tmp_long < 0 || tmp_long > UID_T_MAX)
+	      || !(0 <= tmp_long && (uid_t) tmp_long <= UID_T_MAX))
 	    error (EXIT_FAILURE, 0, _("invalid user %s"), quote (owner_name));
 	  owner_id = (uid_t) tmp_long;
 	}
@@ -578,7 +578,7 @@ get_ids (void)
 	{
 	  long int tmp_long;
 	  if (xstrtol (group_name, NULL, 0, &tmp_long, NULL) != LONGINT_OK
-	      || tmp_long < 0 || tmp_long > GID_T_MAX)
+	      || !(0 <= tmp_long && (gid_t) tmp_long <= GID_T_MAX))
 	    error (EXIT_FAILURE, 0, _("invalid group %s"), quote (group_name));
 	  group_id = (gid_t) tmp_long;
 	}