From: Linus Torvalds Date: Fri, 20 Aug 2010 23:49:40 +0000 (-0700) Subject: mm: make stack guard page logic use vm_prev pointer X-Git-Tag: accepted/tizen/common/20141203.182822~10315 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=0e8e50e20c837eeec8323bba7dcd25fe5479194c;p=platform%2Fkernel%2Flinux-arm64.git mm: make stack guard page logic use vm_prev pointer Like the mlock() change previously, this makes the stack guard check code use vma->vm_prev to see what the mapping below the current stack is, rather than have to look it up with find_vma(). Also, accept an abutting stack segment, since that happens naturally if you split the stack with mlock or mprotect. Tested-by: Ian Campbell Signed-off-by: Linus Torvalds --- diff --git a/mm/memory.c b/mm/memory.c index b6e5fd2..2ed2267 100644 --- a/mm/memory.c +++ b/mm/memory.c @@ -2770,11 +2770,18 @@ static inline int check_stack_guard_page(struct vm_area_struct *vma, unsigned lo { address &= PAGE_MASK; if ((vma->vm_flags & VM_GROWSDOWN) && address == vma->vm_start) { - address -= PAGE_SIZE; - if (find_vma(vma->vm_mm, address) != vma) - return -ENOMEM; + struct vm_area_struct *prev = vma->vm_prev; + + /* + * Is there a mapping abutting this one below? + * + * That's only ok if it's the same stack mapping + * that has gotten split.. + */ + if (prev && prev->vm_end == address) + return prev->vm_flags & VM_GROWSDOWN ? 0 : -ENOMEM; - expand_stack(vma, address); + expand_stack(vma, address - PAGE_SIZE); } return 0; }