From: Behdad Esfahbod <behdad@behdad.org>
Date: Fri, 27 May 2011 06:46:28 +0000 (-0400)
Subject: [test/unicode] Fix double-free
X-Git-Tag: submit/2.0alpha-wayland/20121130.004132~9^2~136
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=0e482ec6ba30b613f2d7ee97c61be458c5aebcd6;p=profile%2Fivi%2Forg.tizen.video-player.git

[test/unicode] Fix double-free

Caught by "make check-valgrind".
---

diff --git a/test/Makefile.am b/test/Makefile.am
index 4d6c460..46b21be 100644
--- a/test/Makefile.am
+++ b/test/Makefile.am
@@ -102,7 +102,7 @@ valgrind_verbose = $(valgrind_verbose_$(V))
 valgrind_verbose_ = $(valgrind_verbose_$(AM_DEFAULT_VERBOSITY))
 valgrind_verbose_0 = | \
 	grep '\(^[^=]\|ERROR SUMMARY\|definitely lost\|indirectly lost\)' | grep -v ': 0'
-
+# TODO: The following check does not fail if valgrind finds error.  It should.
 check-valgrind:
 	$(AM_V_at)$(MAKE) $(AM_MAKEFLGS) check-tool TOOL="valgrind $(VALGRIND_FLAGS)" \
 	2>&1 | tee valgrind-log $(valgrind_verbose)
diff --git a/test/test-unicode.c b/test/test-unicode.c
index e163aba..cce4fd2 100644
--- a/test/test-unicode.c
+++ b/test/test-unicode.c
@@ -633,8 +633,6 @@ test_unicode_setters (void)
     g_assert (data[0].freed && !data[1].freed);
     hb_unicode_funcs_destroy (uf);
     g_assert (data[0].freed && !data[1].freed);
-
-    hb_unicode_funcs_destroy (uf);
   }
 }