From: Uwe Kleine-König Date: Tue, 14 Feb 2023 16:28:29 +0000 (+0100) Subject: hwrng: xgene - Improve error reporting for problems during .remove() X-Git-Tag: v6.6.7~2762^2~139 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=0e44db95eecb30aade0cac6cb8450e8bceeff4d2;p=platform%2Fkernel%2Flinux-starfive.git hwrng: xgene - Improve error reporting for problems during .remove() Returning an error value in a platform driver's remove callback results in a generic error message being emitted by the driver core, but otherwise it doesn't make a difference. The device goes away anyhow. As the driver already emits a better error message than the core, suppress the generic error message by returning zero unconditionally. Signed-off-by: Uwe Kleine-König Signed-off-by: Herbert Xu --- diff --git a/drivers/char/hw_random/xgene-rng.c b/drivers/char/hw_random/xgene-rng.c index 3166261..c67d318 100644 --- a/drivers/char/hw_random/xgene-rng.c +++ b/drivers/char/hw_random/xgene-rng.c @@ -366,7 +366,7 @@ static int xgene_rng_remove(struct platform_device *pdev) if (rc) dev_err(&pdev->dev, "RNG init wakeup failed error %d\n", rc); - return rc; + return 0; } static const struct of_device_id xgene_rng_of_match[] = {