From: Devendra Naga Date: Sat, 21 Jul 2012 08:37:58 +0000 (+0545) Subject: pinctrl/pinctrl-u300: remove unneeded devm_kfree call X-Git-Tag: upstream/snapshot3+hdmi~6854^2~4 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=0e3ac20d9f9872cbf2d00d6a63f92759cb8dd082;p=platform%2Fadaptation%2Frenesas_rcar%2Frenesas_kernel.git pinctrl/pinctrl-u300: remove unneeded devm_kfree call the allocated memory will be destroyed at the driver unload time, automatically if driver uses the devm_ functions, so no need of doing devm_kfree at the error path Signed-off-by: Devendra Naga Signed-off-by: Linus Walleij --- diff --git a/drivers/pinctrl/pinctrl-u300.c b/drivers/pinctrl/pinctrl-u300.c index a7ad8c1..309f5b9 100644 --- a/drivers/pinctrl/pinctrl-u300.c +++ b/drivers/pinctrl/pinctrl-u300.c @@ -1121,10 +1121,8 @@ static int __devinit u300_pmx_probe(struct platform_device *pdev) upmx->dev = &pdev->dev; res = platform_get_resource(pdev, IORESOURCE_MEM, 0); - if (!res) { - ret = -ENOENT; - goto out_no_resource; - } + if (!res) + return -ENOENT; upmx->phybase = res->start; upmx->physize = resource_size(res); @@ -1165,8 +1163,6 @@ out_no_remap: platform_set_drvdata(pdev, NULL); out_no_memregion: release_mem_region(upmx->phybase, upmx->physize); -out_no_resource: - devm_kfree(&pdev->dev, upmx); return ret; }