From: danakj@chromium.org Date: Tue, 17 Apr 2012 00:21:46 +0000 (+0000) Subject: [chromium] Consistent checking for clipped rects when we need the computed result... X-Git-Tag: 070512121124~6859 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=0e36bf5d4761aedc4035b109ca31f08803ac28d8;p=profile%2Fivi%2Fwebkit-efl.git [chromium] Consistent checking for clipped rects when we need the computed result enclosed within the real result https://bugs.webkit.org/show_bug.cgi?id=83543 Reviewed by Adrienne Walker. It should not be possible to make a rect in layer space that is clipped by the camera but for which the screen space transform gives a rectilinear output. But use consistent methods for checking that the result remains enclosed within the actual pixels. One day when clipped is true, we can find an interior axis-aligned rect within the clipped result, and checking clipped explicitly makes this more clear. Covered by existing tests. * platform/graphics/chromium/cc/CCOcclusionTracker.cpp: (WebCore::computeOcclusionBehindLayer): (WebCore::::markOccludedBehindLayer): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114324 268f45cc-cd09-0410-ab3c-d52691b4dbfc --- diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog index 28a431b..b8294c6 100644 --- a/Source/WebCore/ChangeLog +++ b/Source/WebCore/ChangeLog @@ -1,3 +1,25 @@ +2012-04-16 Dana Jansens + + [chromium] Consistent checking for clipped rects when we need the computed result enclosed within the real result + https://bugs.webkit.org/show_bug.cgi?id=83543 + + Reviewed by Adrienne Walker. + + It should not be possible to make a rect in layer space that is clipped + by the camera but for which the screen space transform gives a + rectilinear output. But use consistent methods for checking that the + result remains enclosed within the actual pixels. + + One day when clipped is true, we can find an interior axis-aligned rect + within the clipped result, and checking clipped explicitly makes this + more clear. + + Covered by existing tests. + + * platform/graphics/chromium/cc/CCOcclusionTracker.cpp: + (WebCore::computeOcclusionBehindLayer): + (WebCore::::markOccludedBehindLayer): + 2012-04-16 Erik Arvidsson [V8] Don't delete the per context data until the V8IsolatedContext is deleted