From: Yu Liao Date: Wed, 23 Aug 2023 02:00:51 +0000 (+0800) Subject: rv: Set variable 'da_mon_##name' to static X-Git-Tag: v6.6.17~3930^2~28 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=0e19543b7b0cbc47fd9cac01cd7738f14f381c70;p=platform%2Fkernel%2Flinux-rpi.git rv: Set variable 'da_mon_##name' to static gcc with W=1 reports kernel/trace/rv/monitors/wip/wip.c:20:1: sparse: sparse: symbol 'da_mon_wip' was not declared. Should it be static? The per-cpu variable 'da_mon_##name' is only used in its defining file, so it should be static. Link: https://lore.kernel.org/linux-trace-kernel/20230823020051.3184953-1-liaoyu15@huawei.com Reported-by: kernel test robot Closes: https://lore.kernel.org/oe-kbuild-all/202307280030.7EjUG9gR-lkp@intel.com/ Signed-off-by: Yu Liao Acked-by: Daniel Bristot de Oliveira Signed-off-by: Steven Rostedt (Google) --- diff --git a/include/rv/da_monitor.h b/include/rv/da_monitor.h index 9eb7568..9705b2a 100644 --- a/include/rv/da_monitor.h +++ b/include/rv/da_monitor.h @@ -262,7 +262,7 @@ static inline void da_monitor_destroy_##name(void) \ /* \ * per-cpu monitor variables \ */ \ -DEFINE_PER_CPU(struct da_monitor, da_mon_##name); \ +static DEFINE_PER_CPU(struct da_monitor, da_mon_##name); \ \ /* \ * da_get_monitor_##name - return current CPU monitor address \