From: Patrick McHardy <kaber@trash.net>
Date: Tue, 12 Apr 2011 05:39:51 +0000 (+0000)
Subject: connector: fix skb double free in cn_rx_skb()
X-Git-Tag: upstream/snapshot3+hdmi~10447^2~89
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=0e08785845093ef4ed220463a739bc8d0db95de7;p=platform%2Fadaptation%2Frenesas_rcar%2Frenesas_kernel.git

connector: fix skb double free in cn_rx_skb()

When a skb is delivered to a registered callback, cn_call_callback()
incorrectly returns -ENODEV after freeing the skb, causing cn_rx_skb()
to free the skb a second time.

Reported-by: Eric B Munson <emunson@mgebm.net>
Signed-off-by: Patrick McHardy <kaber@trash.net>
Tested-by: Eric B Munson <emunson@mgebm.net>
Signed-off-by: David S. Miller <davem@davemloft.net>
---

diff --git a/drivers/connector/connector.c b/drivers/connector/connector.c
index d770058..219d88a 100644
--- a/drivers/connector/connector.c
+++ b/drivers/connector/connector.c
@@ -142,6 +142,7 @@ static int cn_call_callback(struct sk_buff *skb)
 		cbq->callback(msg, nsp);
 		kfree_skb(skb);
 		cn_queue_release_callback(cbq);
+		err = 0;
 	}
 
 	return err;