From: Lino Sanfilippo Date: Thu, 24 Nov 2022 13:55:35 +0000 (+0100) Subject: tpm, tpm_tis: Claim locality in interrupt handler X-Git-Tag: v6.6.7~3073^2~10 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=0e069265bce5a40c4eee52e2364bbbd4dabee94a;p=platform%2Fkernel%2Flinux-starfive.git tpm, tpm_tis: Claim locality in interrupt handler Writing the TPM_INT_STATUS register in the interrupt handler to clear the interrupts only has effect if a locality is held. Since this is not guaranteed at the time the interrupt is fired, claim the locality explicitly in the handler. Signed-off-by: Lino Sanfilippo Tested-by: Michael Niewöhner Tested-by: Jarkko Sakkinen Reviewed-by: Jarkko Sakkinen Signed-off-by: Jarkko Sakkinen --- diff --git a/drivers/char/tpm/tpm_tis_core.c b/drivers/char/tpm/tpm_tis_core.c index bd443cf..fda4ed6 100644 --- a/drivers/char/tpm/tpm_tis_core.c +++ b/drivers/char/tpm/tpm_tis_core.c @@ -776,7 +776,9 @@ static irqreturn_t tis_int_handler(int dummy, void *dev_id) wake_up_interruptible(&priv->int_queue); /* Clear interrupts handled with TPM_EOI */ + tpm_tis_request_locality(chip, 0); rc = tpm_tis_write32(priv, TPM_INT_STATUS(priv->locality), interrupt); + tpm_tis_relinquish_locality(chip, 0); if (rc < 0) return IRQ_NONE;