From: Zhao Qiang Date: Tue, 5 May 2015 07:53:33 +0000 (+0800) Subject: driver/qe: use strncpy instead of strcpy X-Git-Tag: v2015.10-rc2~424^2~20 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=0e0224ee627a71191a4e704c367c09723b995993;p=platform%2Fkernel%2Fu-boot.git driver/qe: use strncpy instead of strcpy strncpy is safer than strcpy, use it to instead of strcpy. Signed-off-by: Zhao Qiang Reviewed-by: York Sun --- diff --git a/drivers/qe/qe.c b/drivers/qe/qe.c index f1df0a4..08620b2 100644 --- a/drivers/qe/qe.c +++ b/drivers/qe/qe.c @@ -435,7 +435,7 @@ int qe_upload_firmware(const struct qe_firmware *firmware) * saved microcode information and put in the new. */ memset(&qe_firmware_info, 0, sizeof(qe_firmware_info)); - strcpy(qe_firmware_info.id, (char *)firmware->id); + strncpy(qe_firmware_info.id, (char *)firmware->id, 62); qe_firmware_info.extended_modes = firmware->extended_modes; memcpy(qe_firmware_info.vtraps, firmware->vtraps, sizeof(firmware->vtraps));