From: Rafael Espindola <rafael.espindola@gmail.com>
Date: Tue, 2 Feb 2016 15:45:37 +0000 (+0000)
Subject: Expand comment a bit.
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=0df1b0bf42cfef549ebba09f2e7457c676504495;p=platform%2Fupstream%2Fllvm.git

Expand comment a bit.

I have spent some time prototyping this idea. While it seems to work, I
now think it is probably not worth it.

llvm-svn: 259516
---

diff --git a/lld/ELF/Writer.cpp b/lld/ELF/Writer.cpp
index f9d0303..3a317b3 100644
--- a/lld/ELF/Writer.cpp
+++ b/lld/ELF/Writer.cpp
@@ -247,6 +247,11 @@ static bool handleTlsRelocation(unsigned Type, SymbolBody *Body,
 // * Apply relocations, recording which ones require a dynamic reloc.
 // * Write the dynamic relocations.
 // * Write the rest of the file.
+// This would have some drawbacks. For example, we would only know if .rela.dyn
+// is needed after applying relocations. If it is, it will go after rw and rx
+// sections. Given that it is ro, we will need an extra PT_LOAD. This
+// complicates things for the dynamic linker and means we would have to reserve
+// space for the extra PT_LOAD even if we end up not using it.
 template <class ELFT>
 template <bool isRela>
 void Writer<ELFT>::scanRelocs(