From: Paul Berry <stereotype441@gmail.com>
Date: Mon, 9 Jul 2012 19:50:31 +0000 (-0700)
Subject: i965/blorp: Loosen assertions in compute_msaa_layout_for_pipeline.
X-Git-Tag: accepted/2.0alpha-wayland/20121114.171706~1094
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=0dd5e98aa5c146ef21ab44b34fb7714206d5ec08;hp=989218b9801f0afd0cbadce19a5719b0aa0deb70;p=profile%2Fivi%2Fmesa.git

i965/blorp: Loosen assertions in compute_msaa_layout_for_pipeline.

Previously, on Gen7, compute_msaa_layout_for_pipeline() would verify
that IMS layout is not used.  However, now that we configure
SURFACE_STATE correctly for IMS surfaces, IMS layout is available.

Reviewed-by: Anuj Phogat <anuj.phogat@gmail.com>
---

diff --git a/src/mesa/drivers/dri/i965/brw_blorp_blit.cpp b/src/mesa/drivers/dri/i965/brw_blorp_blit.cpp
index c8db662..c5e0ef9 100644
--- a/src/mesa/drivers/dri/i965/brw_blorp_blit.cpp
+++ b/src/mesa/drivers/dri/i965/brw_blorp_blit.cpp
@@ -1432,20 +1432,15 @@ compute_msaa_layout_for_pipeline(struct brw_context *brw, unsigned num_samples,
       assert(true_layout == INTEL_MSAA_LAYOUT_NONE ||
              true_layout == INTEL_MSAA_LAYOUT_IMS);
       return INTEL_MSAA_LAYOUT_NONE;
+   } else {
+      assert(true_layout != INTEL_MSAA_LAYOUT_NONE);
    }
 
    /* Prior to Gen7, all MSAA surfaces use IMS layout. */
    if (brw->intel.gen == 6) {
       assert(true_layout == INTEL_MSAA_LAYOUT_IMS);
-      return INTEL_MSAA_LAYOUT_IMS;
    }
 
-   /* Since blorp uses color textures and render targets to do all its work
-    * (even when blitting stencil and depth data), we always have to configure
-    * the Gen7 GPU to use UMS or CMS layout on Gen7.
-    */
-   assert(true_layout == INTEL_MSAA_LAYOUT_UMS ||
-          true_layout == INTEL_MSAA_LAYOUT_CMS);
    return true_layout;
 }