From: Michal Kazior <michal.kazior@tieto.com>
Date: Wed, 31 Jul 2013 08:55:14 +0000 (+0200)
Subject: ath10k: zero arvif memory on add_interface()
X-Git-Tag: upstream/snapshot3+hdmi~3994^2~225^2~25^2~75
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=0dbd09e6284dc7c3de1470e2f1a3c83e0a0fc591;p=platform%2Fadaptation%2Frenesas_rcar%2Frenesas_kernel.git

ath10k: zero arvif memory on add_interface()

The private memory area in vif provided by
mac80211 isn't guaranteed to be zeroed.

This patch should fix issues when switching
between STA and AP interface types.

The tim_bitmap could become polluted by STA bssid
field (since it's a union), wep_keys array
could also become polluted with invalid pointers
and probably much more.

Signed-off-by: Michal Kazior <michal.kazior@tieto.com>
Signed-off-by: Kalle Valo <kvalo@qca.qualcomm.com>
---

diff --git a/drivers/net/wireless/ath/ath10k/mac.c b/drivers/net/wireless/ath/ath10k/mac.c
index 47c1163..cf2ba4d 100644
--- a/drivers/net/wireless/ath/ath10k/mac.c
+++ b/drivers/net/wireless/ath/ath10k/mac.c
@@ -1925,6 +1925,8 @@ static int ath10k_add_interface(struct ieee80211_hw *hw,
 
 	mutex_lock(&ar->conf_mutex);
 
+	memset(arvif, 0, sizeof(*arvif));
+
 	arvif->ar = ar;
 	arvif->vif = vif;