From: Ovidiu Panait Date: Tue, 29 Sep 2020 17:27:13 +0000 (+0300) Subject: pinctrl: bcm283x: Store the return value of dev_read_u32_default to int X-Git-Tag: v2021.10~497^2~2^2 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=0db912de153743e2ec97bd022640c5722eb07737;p=platform%2Fkernel%2Fu-boot.git pinctrl: bcm283x: Store the return value of dev_read_u32_default to int Currently, the return value of dev_read_u32_default is stored in an u32, causing the subsequent "if (function < 0)" to always be false: u32 function; ... function = dev_read_u32_default(config, "brcm,function", -1); if (function < 0) { debug("Failed reading function for pinconfig %s (%d)\n", config->name, function); return -EINVAL; } Make "function" variable an int to fix this. Cc: Matthias Brugger Signed-off-by: Ovidiu Panait Signed-off-by: Matthias Brugger --- diff --git a/drivers/pinctrl/broadcom/pinctrl-bcm283x.c b/drivers/pinctrl/broadcom/pinctrl-bcm283x.c index 49791c5..41da814 100644 --- a/drivers/pinctrl/broadcom/pinctrl-bcm283x.c +++ b/drivers/pinctrl/broadcom/pinctrl-bcm283x.c @@ -63,7 +63,7 @@ static int bcm2835_gpio_get_func_id(struct udevice *dev, unsigned int gpio) int bcm283x_pinctrl_set_state(struct udevice *dev, struct udevice *config) { u32 pin_arr[MAX_PINS_PER_BANK]; - u32 function; + int function; int i, len, pin_count = 0; if (!dev_read_prop(config, "brcm,pins", &len) || !len ||