From: Dan Carpenter <dan.carpenter@oracle.com>
Date: Tue, 4 Nov 2014 08:55:09 +0000 (+0300)
Subject: ieee802154: || vs && in ieee802154_is_valid_extended_addr()
X-Git-Tag: v5.15~16635^2~17^2~6^2~213
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=0d8a52f933f817d0b62955a5a362fb7f2508f06c;p=platform%2Fkernel%2Flinux-starfive.git

ieee802154: || vs && in ieee802154_is_valid_extended_addr()

The ieee802154_is_valid_extended_addr() always returns true because
there is a typo.  The || should be &&.  Neither 0x0000000000000000ULL
nor 0xffffffffffffffffULL are valid addresses.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Alexander Aring <alex.aring@gmail.com>
Signed-off-by: Marcel Holtmann <marcel@holtmann.org>
---

diff --git a/include/linux/ieee802154.h b/include/linux/ieee802154.h
index 5d9e745..4c03286 100644
--- a/include/linux/ieee802154.h
+++ b/include/linux/ieee802154.h
@@ -209,7 +209,7 @@ static inline bool ieee802154_is_valid_extended_addr(const __le64 addr)
 	 * This is currently a workaround because neighbor discovery can't
 	 * deal with short addresses types right now.
 	 */
-	return ((addr != cpu_to_le64(0x0000000000000000ULL)) ||
+	return ((addr != cpu_to_le64(0x0000000000000000ULL)) &&
 		(addr != cpu_to_le64(0xffffffffffffffffULL)));
 }