From: Dan Carpenter <dan.carpenter@oracle.com>
Date: Thu, 29 Aug 2013 08:47:00 +0000 (+0300)
Subject: mISDN: return -EINVAL on error in dsp_control_req()
X-Git-Tag: v4.9.8~7972^2~2
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=0d63c27d9e879a0b54eb405636d60ab12040ca46;p=platform%2Fkernel%2Flinux-rpi3.git

mISDN: return -EINVAL on error in dsp_control_req()

If skb->len is too short then we should return an error.  Otherwise we
read beyond the end of skb->data for several bytes.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
---

diff --git a/drivers/isdn/mISDN/dsp_core.c b/drivers/isdn/mISDN/dsp_core.c
index 22b720e..77025f5 100644
--- a/drivers/isdn/mISDN/dsp_core.c
+++ b/drivers/isdn/mISDN/dsp_core.c
@@ -288,8 +288,10 @@ dsp_control_req(struct dsp *dsp, struct mISDNhead *hh, struct sk_buff *skb)
 	u8 *data;
 	int len;
 
-	if (skb->len < sizeof(int))
+	if (skb->len < sizeof(int)) {
 		printk(KERN_ERR "%s: PH_CONTROL message too short\n", __func__);
+		return -EINVAL;
+	}
 	cont = *((int *)skb->data);
 	len = skb->len - sizeof(int);
 	data = skb->data + sizeof(int);