From: Johan Hovold Date: Wed, 11 Nov 2015 09:07:02 +0000 (+0100) Subject: greybus: loopback: fix layer violation X-Git-Tag: v4.14-rc1~2366^2~378^2~21^2~1050 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=0d1d6ee209e1129c584c2b00a48a33ff1fb7312c;p=platform%2Fkernel%2Flinux-rpi.git greybus: loopback: fix layer violation A bundle (protocol) driver has no business creating sysfs entries for an ancestor device. Move the sysfs entries to the bundle device for now. Signed-off-by: Johan Hovold Reviewed-by: Bryan O'Donoghue Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/staging/greybus/loopback.c b/drivers/staging/greybus/loopback.c index e1b1be0..9a44dcc 100644 --- a/drivers/staging/greybus/loopback.c +++ b/drivers/staging/greybus/loopback.c @@ -921,7 +921,7 @@ static int gb_loopback_connection_init(struct gb_connection *connection) struct gb_loopback *gb; int retval; char name[DEBUGFS_NAMELEN]; - struct kobject *kobj = &connection->hd->endo->dev.kobj; + struct kobject *kobj = &connection->bundle->dev.kobj; gb = kzalloc(sizeof(*gb), GFP_KERNEL); if (!gb) @@ -1010,7 +1010,7 @@ out_sysfs: static void gb_loopback_connection_exit(struct gb_connection *connection) { struct gb_loopback *gb = connection->bundle->private; - struct kobject *kobj = &connection->hd->endo->dev.kobj; + struct kobject *kobj = &connection->bundle->dev.kobj; if (!IS_ERR_OR_NULL(gb->task)) kthread_stop(gb->task);